Add basestation configuration #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florisheinen1
requested review from
emielsteerneman,
casdoorn and
skaeringur97
| ], | ||
| "BasestationConfiguration" : [ | ||
| ["header", 8, None, "Header byte indicating the type of packet"], | ||
| ["remVersion", 4, None, "Version of roboteam_embedded_messages"], |
There was a problem hiding this comment.
remVersion should be 5 now right?
There was a problem hiding this comment.
4 stands for 4 bits used, not for the version
|
Looks good to me |
emielsteerneman
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to alter the frequency of basestations from within Robothub. This requires a message that can get the frequency and set the frequency.
This can be done with a general configuration message, to which other things can be added besides frequency in the future if necessary.
Because there is a practical limit of teams (2), only two frequencies will be used. To ensure the basestation can handle the new frequency, and to ensure it does not collide with others, I abstracted frequency from the messages, and want to make use of predefined channels: channel 0 and channel 1, (hence only a single bit for frequency)